Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update models without serviceid, add config to manifest #2732

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

stobrien89
Copy link
Member

Description of changes:
Sync out-of-date models without the serviceId attribute. Additionally adds a config option to the manifest file for per-service endpoint url config.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@SamRemis SamRemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change $config to $configKey

@stobrien89 stobrien89 merged commit 803e9c2 into aws:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants